• Bart Van Assche's avatar
    scsi: Avoid that SCSI queues get stuck · 36e3cf27
    Bart Van Assche authored
    If a .queue_rq() function returns BLK_MQ_RQ_QUEUE_BUSY then the block
    driver that implements that function is responsible for rerunning the
    hardware queue once requests can be queued again successfully.
    
    commit 52d7f1b5 ("blk-mq: Avoid that requeueing starts stopped
    queues") removed the blk_mq_stop_hw_queue() call from scsi_queue_rq()
    for the BLK_MQ_RQ_QUEUE_BUSY case. Hence change all calls to functions
    that are intended to rerun a busy queue such that these examine all
    hardware queues instead of only stopped queues.
    
    Since no other functions than scsi_internal_device_block() and
    scsi_internal_device_unblock() should ever stop or restart a SCSI
    queue, change the blk_mq_delay_queue() call into a
    blk_mq_delay_run_hw_queue() call.
    
    Fixes: commit 52d7f1b5 ("blk-mq: Avoid that requeueing starts stopped queues")
    Fixes: commit 7e79dadc ("blk-mq: stop hardware queue in blk_mq_delay_queue()")
    Signed-off-by: default avatarBart Van Assche <bart.vanassche@sandisk.com>
    Cc: Martin K. Petersen <martin.petersen@oracle.com>
    Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
    Cc: Christoph Hellwig <hch@lst.de>
    Cc: Hannes Reinecke <hare@suse.de>
    Cc: Sagi Grimberg <sagi@grimberg.me>
    Cc: Long Li <longli@microsoft.com>
    Cc: K. Y. Srinivasan <kys@microsoft.com>
    Signed-off-by: default avatarJens Axboe <axboe@fb.com>
    36e3cf27
scsi_lib.c 85.8 KB