• Lyude Paul's avatar
    drm/i915: Assume 100% brightness when not in DPCD control mode · 79946723
    Lyude Paul authored
    Currently we always determine the initial panel brightness level by
    simply reading the value from DP_EDP_BACKLIGHT_BRIGHTNESS_MSB/LSB. This
    seems wrong though, because if the panel is not currently in DPCD
    control mode there's not really any reason why there would be any
    brightness value programmed in the first place.
    
    This appears to be the case on the Lenovo ThinkPad X1 Extreme 2nd
    Generation, where the default value in these registers is always 0 on
    boot despite the fact the panel runs at max brightness by default.
    Getting the initial brightness value correct here is important as well,
    since the panel on this laptop doesn't behave well if it's ever put into
    DPCD control mode while the brightness level is programmed to 0.
    
    So, let's fix this by checking what the current backlight control mode
    is before reading the brightness level. If it's in DPCD control mode, we
    return the programmed brightness level. Otherwise we assume 100%
    brightness and return the highest possible brightness level. This also
    prevents us from accidentally programming a brightness level of 0.
    
    This is one of the many fixes that gets backlight controls working on
    the ThinkPad X1 Extreme 2nd Generation with optional 4K AMOLED screen.
    
    Changes since v1:
    * s/DP_EDP_DISPLAY_CONTROL_REGISTER/DP_EDP_BACKLIGHT_MODE_SET_REGISTER/
      - Jani
    Tested-by: default avatarAceLan Kao <acelan.kao@canonical.com>
    Tested-by: default avatarPerry Yuan <pyuan@redhat.com>
    Signed-off-by: default avatarLyude Paul <lyude@redhat.com>
    Signed-off-by: default avatarJani Nikula <jani.nikula@intel.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/20200116211623.53799-3-lyude@redhat.com
    79946723
intel_dp_aux_backlight.c 11.4 KB