• Herbert Xu's avatar
    [IPSEC]: Fix uninitialised dst warning in __xfrm_lookup · 5e5234ff
    Herbert Xu authored
    Andrew Morton reported that __xfrm_lookup generates this warning:
    
    net/xfrm/xfrm_policy.c: In function '__xfrm_lookup':
    net/xfrm/xfrm_policy.c:1449: warning: 'dst' may be used uninitialized in this function
    
    This is because if policy->action is of an unexpected value then dst will
    not be initialised.  Of course, in practice this should never happen since
    the input layer xfrm_user/af_key will filter out all illegal values.  But
    the compiler doesn't know that of course.
    
    So this patch fixes this by taking the conservative approach and treat all
    unknown actions the same as a blocking action.
    
    Thanks to Andrew for finding this and providing an initial fix.
    Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
    5e5234ff
xfrm_policy.c 56 KB