• Matt Redfearn's avatar
    serial: 8250_early: Only set divisor if valid clk & baud · 0ff3ab70
    Matt Redfearn authored
    If either uartclk or baud are 0, avoid calculating and setting a divisor
    based on them since the output will almost certainly be garbage.
    
    This also allows platforms such as the MIPS generic kernel, which has no
    way to know a valid BASE_BASE for the board it is actually booted on at
    compile time, to set BASE_BAUD to 0 and avoid early_8250 setting a bad
    divisor.
    
    This fixes a regression caused by commit 31cb9a85 ("earlycon:
    initialise baud field of earlycon device structure"), which changed the
    behavior of of_setup_earlycon such that it sets a baud rate in the
    earlycon structure where previously it was left as 0. All boards
    supported by the MIPS generic kernel started outputting garbage from the
    boot console due to an incorrect divisor being set.
    
    Fixes: 31cb9a85 ("earlycon: initialise baud field of earlycon device structure")
    Cc: stable <stable@vger.kernel.org> # 4.14
    Signed-off-by: default avatarMatt Redfearn <matt.redfearn@mips.com>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    0ff3ab70
8250_early.c 5.45 KB