• Ravi Bangoria's avatar
    perf annotate: Prefer cmdline option over default config · 812b0f52
    Ravi Bangoria authored
    For all the perf-config options that can also be set from command line
    option, the preference is given to command line version in case of any
    conflict. But that's opposite in case of perf annotate. i.e. the more
    preference is given to default option rather than command line option.
    Fix it.
    
    Before:
    
      $ ./perf config
      annotate.show_nr_samples=false
    
      $ ./perf annotate shash --show-nr-samples
      Percent│
             │24:   mov    -0xc(%rbp),%eax
       49.19 │      imul   $0x1003f,%eax,%ecx
             │      mov    -0x18(%rbp),%rax
    
    After:
    
      Samples│
             │24:   mov    -0xc(%rbp),%eax
           1 │      imul   $0x1003f,%eax,%ecx
             │      mov    -0x18(%rbp),%rax
    Signed-off-by: default avatarRavi Bangoria <ravi.bangoria@linux.ibm.com>
    Tested-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    Cc: Adrian Hunter <adrian.hunter@intel.com>
    Cc: Alexey Budankov <alexey.budankov@linux.intel.com>
    Cc: Changbin Du <changbin.du@intel.com>
    Cc: Ian Rogers <irogers@google.com>
    Cc: Jin Yao <yao.jin@linux.intel.com>
    Cc: Jiri Olsa <jolsa@kernel.org>
    Cc: Leo Yan <leo.yan@linaro.org>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Song Liu <songliubraving@fb.com>
    Cc: Taeung Song <treeze.taeung@gmail.com>
    Cc: Thomas Richter <tmricht@linux.ibm.com>
    Cc: Yisheng Xie <xieyisheng1@huawei.com>
    Link: http://lore.kernel.org/lkml/20200213064306.160480-7-ravi.bangoria@linux.ibm.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    812b0f52
builtin-annotate.c 16.9 KB