• Oleg Nesterov's avatar
    do_generic_file_read: s/EINTR/EIO/ if lock_page_killable() fails · 85462323
    Oleg Nesterov authored
    If lock_page_killable() fails because the task was killed by SIGKILL or
    any other fatal signal, do_generic_file_read() returns -EIO.
    
    This seems to be OK, because in fact the userspace won't see this error,
    the task will dequeue SIGKILL and exit.
    
    However, /sbin/init is different, it will dequeue SIGKILL, ignore it, and
    return to the user-space with the bogus -EIO.
    
    Change the code to return the error code from lock_page_killable(), -EINTR.
    This doesn't fix the bug, but perhaps makes sense anyway. Imho, with this
    change the code looks a bit more logical, and the "good" init should handle
    the spurious EINTR or short read.
    
    Afaics we can also change lock_page_killable() to return -ERESTARTNOINTR,
    but this can't prevent the short reads.
    Signed-off-by: default avatarOleg Nesterov <oleg@tv-sign.ru>
    Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
    85462323
filemap.c 70.3 KB