• Paolo 'Blaisorblade' Giarrusso's avatar
    [PATCH] uml: restore include breakage, breaking binary format of COW driver · 855ec613
    Paolo 'Blaisorblade' Giarrusso authored
    Commit 44456d37, between 2.6.13-rc3 and -rc4,
    was a "nice cleanup" which broke something. Revert the offending part.
    
    It broke because:
    a) because this part doesn't fall under the description
    b) the author didn't know what he was doing here
    c) the author didn't try to compile the existing code and see that it worked
       perfectly.
    d) the author didn't ask us what was happening
    e) you didn't either, and somebody there should have learned that UML is a bit
       different.
    
    In fact, UML is special in linking to host libc and using its includes.
    
    In particular, since host includes always define both __BIG_ENDIAN and
    __LITTLE_ENDIAN, ntohll() macros started thinking to be in a big-endian world;
    and on-disk compatibility was broken.
    
    Many thanks go to Nix for reporting the problem and correctly diagnosing an
    endianness problem.
    
    Btw, this patch restores the previous code, which worked; but the definitions
    would be uncorrect if used in kernelspace files.
    
    Next patch addresses that.
    
    Cc: Nix <nix@esperi.org.uk>, Olaf Hering <olh@suse.de>
    Signed-off-by: default avatarPaolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
    Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
    855ec613
cow.h 1.24 KB