• Joel Becker's avatar
    ocfs2: Fix ocfs2_read_quota_block() error handling. · 85eb8b73
    Joel Becker authored
    ocfs2_bread() has become ocfs2_read_virt_blocks(), with a prototype to
    match ocfs2_read_blocks().  The quota code, converting from
    ocfs2_bread(), wraps the call to ocfs2_read_virt_blocks() in
    ocfs2_read_quota_block().  Unfortunately, the prototype of
    ocfs2_read_quota_block() matches the old prototype of ocfs2_bread().
    
    The problem is that ocfs2_bread() returned the buffer head, and callers
    assumed that a NULL pointer was indicative of error.  It wasn't.  This
    is why ocfs2_bread() took an int*err argument as well.
    
    The new prototype of ocfs2_read_virt_blocks() avoids this error handling
    confusion.  Let's change ocfs2_read_quota_block() to match.
    Signed-off-by: default avatarJoel Becker <joel.becker@oracle.com>
    Acked-by: default avatarJan Kara <jack@suse.cz>
    Signed-off-by: default avatarMark Fasheh <mfasheh@suse.com>
    85eb8b73
quota_local.c 33.6 KB