• Kunihiko Hayashi's avatar
    net: phy: Fix the issue that netif always links up after resuming · 8742beb5
    Kunihiko Hayashi authored
    Even though the link is down before entering hibernation,
    there is an issue that the network interface always links up after resuming
    from hibernation.
    
    If the link is still down before enabling the network interface,
    and after resuming from hibernation, the phydev->state is forcibly set
    to PHY_UP in mdio_bus_phy_restore(), and the link becomes up.
    
    In suspend sequence, only if the PHY is attached, mdio_bus_phy_suspend()
    calls phy_stop_machine(), and mdio_bus_phy_resume() calls
    phy_start_machine().
    In resume sequence, it's enough to do the same as mdio_bus_phy_resume()
    because the state has been preserved.
    
    This patch fixes the issue by calling phy_start_machine() in
    mdio_bus_phy_restore() in the same way as mdio_bus_phy_resume().
    
    Fixes: bc87922f ("phy: Move PHY PM operations into phy_device")
    Suggested-by: default avatarHeiner Kallweit <hkallweit1@gmail.com>
    Signed-off-by: default avatarKunihiko Hayashi <hayashi.kunihiko@socionext.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    8742beb5
phy_device.c 59 KB