• Jann Horn's avatar
    x86/fpu: Fix __user annotations · 89833fab
    Jann Horn authored
    In save_xstate_epilog(), use __user when type-casting userspace
    pointers.
    
    In setup_sigcontext() and x32_setup_rt_frame(), cast the userspace
    pointers to 'unsigned long __user *' before writing into them. These
    pointers are originally '__u32 __user *' or '__u64 __user *', causing
    sparse to complain when a userspace pointer is written into them. The
    casts are okay because the pointers always point to pointer-sized
    values.
    
    Thanks to Luc Van Oostenryck and Al Viro for explaining this to me.
    Signed-off-by: default avatarJann Horn <jannh@google.com>
    Signed-off-by: default avatarBorislav Petkov <bp@suse.de>
    Cc: Andy Lutomirski <luto@kernel.org>
    Cc: "H. Peter Anvin" <hpa@zytor.com>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
    Cc: Mukesh Ojha <mojha@codeaurora.org>
    Cc: Qiaowei Ren <qiaowei.ren@intel.com>
    Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: Will Deacon <will.deacon@arm.com>
    Cc: x86-ml <x86@kernel.org>
    Link: https://lkml.kernel.org/r/20190329214652.258477-3-jannh@google.com
    89833fab
signal.c 11.8 KB