• Dmitry Vyukov's avatar
    locking/lockdep: Fix stack trace caching logic · 8a5fd564
    Dmitry Vyukov authored
    check_prev_add() caches saved stack trace in static trace variable
    to avoid duplicate save_trace() calls in dependencies involving trylocks.
    But that caching logic contains a bug. We may not save trace on first
    iteration due to early return from check_prev_add(). Then on the
    second iteration when we actually need the trace we don't save it
    because we think that we've already saved it.
    
    Let check_prev_add() itself control when stack is saved.
    
    There is another bug. Trace variable is protected by graph lock.
    But we can temporary release graph lock during printing.
    
    Fix this by invalidating cached stack trace when we release graph lock.
    Signed-off-by: default avatarDmitry Vyukov <dvyukov@google.com>
    Cc: Andrew Morton <akpm@linux-foundation.org>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: glider@google.com
    Cc: kcc@google.com
    Cc: peter@hurleysoftware.com
    Cc: sasha.levin@oracle.com
    Link: http://lkml.kernel.org/r/1454593240-121647-1-git-send-email-dvyukov@google.comSigned-off-by: default avatarIngo Molnar <mingo@kernel.org>
    8a5fd564
lockdep.c 105 KB