• Herbert Xu's avatar
    virtio_net: Fix napi poll list corruption · 8acdf999
    Herbert Xu authored
    The commit d75b1ade (net: less
    interrupt masking in NAPI) breaks virtio_net in an insidious way.
    
    It is now required that if the entire budget is consumed when poll
    returns, the napi poll_list must remain empty.  However, like some
    other drivers virtio_net tries to do a last-ditch check and if
    there is more work it will call napi_schedule and then immediately
    process some of this new work.  Should the entire budget be consumed
    while processing such new work then we will violate the new caller
    contract.
    
    This patch fixes this by not touching any work when we reschedule
    in virtio_net.
    
    The worst part of this bug is that the list corruption causes other
    napi users to be moved off-list.  In my case I was chasing a stall
    in IPsec (IPsec uses netif_rx) and I only belatedly realised that it
    was virtio_net which caused the stall even though the virtio_net
    poll was still functioning perfectly after IPsec stalled.
    Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
    Acked-by: default avatarJason Wang <jasowang@redhat.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    8acdf999
virtio_net.c 51.1 KB