• David Howells's avatar
    rxrpc: Don't put crypto buffers on the stack · 8c2f826d
    David Howells authored
    Don't put buffers of data to be handed to crypto on the stack as this may
    cause an assertion failure in the kernel (see below).  Fix this by using an
    kmalloc'd buffer instead.
    
    kernel BUG at ./include/linux/scatterlist.h:147!
    ...
    RIP: 0010:rxkad_encrypt_response.isra.6+0x191/0x1b0 [rxrpc]
    RSP: 0018:ffffbe2fc06cfca8 EFLAGS: 00010246
    RAX: 0000000000000000 RBX: ffff989277d59900 RCX: 0000000000000028
    RDX: 0000259dc06cfd88 RSI: 0000000000000025 RDI: ffffbe30406cfd88
    RBP: ffffbe2fc06cfd60 R08: ffffbe2fc06cfd08 R09: ffffbe2fc06cfd08
    R10: 0000000000000000 R11: 0000000000000000 R12: 1ffff7c5f80d9f95
    R13: ffffbe2fc06cfd88 R14: ffff98927a3f7aa0 R15: ffffbe2fc06cfd08
    FS:  0000000000000000(0000) GS:ffff98927fc00000(0000) knlGS:0000000000000000
    CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
    CR2: 000055b1ff28f0f8 CR3: 000000001b412003 CR4: 00000000003606f0
    DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
    DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
    Call Trace:
     rxkad_respond_to_challenge+0x297/0x330 [rxrpc]
     rxrpc_process_connection+0xd1/0x690 [rxrpc]
     ? process_one_work+0x1c3/0x680
     ? __lock_is_held+0x59/0xa0
     process_one_work+0x249/0x680
     worker_thread+0x3a/0x390
     ? process_one_work+0x680/0x680
     kthread+0x121/0x140
     ? kthread_create_worker_on_cpu+0x70/0x70
     ret_from_fork+0x3a/0x50
    Reported-by: default avatarJonathan Billings <jsbillings@jsbillings.org>
    Reported-by: default avatarMarc Dionne <marc.dionne@auristor.com>
    Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
    Tested-by: default avatarJonathan Billings <jsbillings@jsbillings.org>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    8c2f826d
rxkad.c 31.3 KB