• Darrick J. Wong's avatar
    xfs: don't write a corrupt unmount record to force summary counter recalc · 5cc3c006
    Darrick J. Wong authored
    In commit f467cad9, I added the ability to force a recalculation of
    the filesystem summary counters if they seemed incorrect.  This was done
    (not entirely correctly) by tweaking the log code to write an unmount
    record without the UMOUNT_TRANS flag set.  At next mount, the log
    recovery code will fail to find the unmount record and go into recovery,
    which triggers the recalculation.
    
    What actually gets written to the log is what ought to be an unmount
    record, but without any flags set to indicate what kind of record it
    actually is.  This worked to trigger the recalculation, but we shouldn't
    write bogus log records when we could simply write nothing.
    
    Fixes: f467cad9 ("xfs: force summary counter recalc at next mount")
    Signed-off-by: default avatarDarrick J. Wong <darrick.wong@oracle.com>
    Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
    Reviewed-by: default avatarBrian Foster <bfoster@redhat.com>
    5cc3c006
xfs_log.c 105 KB