• Magnus Damm's avatar
    vmcore: remove saved_max_pfn check · 921d58c0
    Magnus Damm authored
    Remove the saved_max_pfn check from the /proc/vmcore function
    read_from_oldmem().  No need to verify, we should be able to just trust
    that "elfcorehdr=" is correctly passed to the crash kernel on the kernel
    command line like we do with other parameters.
    
    The read_from_oldmem() function in fs/proc/vmcore.c is quite similar to
    read_from_oldmem() in drivers/char/mem.c, but only in the latter it makes
    sense to use saved_max_pfn.  For oldmem it is used to determine when to
    stop reading.  For vmcore we already have the elf header info pointing out
    the physical memory regions, no need to pass the end-of- old-memory twice.
    
    Removing the saved_max_pfn check from vmcore makes it possible for
    architectures to skip oldmem but still support crash dump through vmcore -
    without the need for the old saved_max_pfn cruft.
    
    Architectures that want to play safe can do the saved_max_pfn check in
    copy_oldmem_page().  Not sure why anyone would want to do that, but that's
    even safer than today - the saved_max_pfn check in vmcore removed by this
    patch only checks the first page.
    Signed-off-by: default avatarMagnus Damm <damm@igel.co.jp>
    Acked-by: default avatarVivek Goyal <vgoyal@redhat.com>
    Acked-by: default avatarSimon Horman <horms@verge.net.au>
    Cc: "Eric W. Biederman" <ebiederm@xmission.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    921d58c0
vmcore.c 16.1 KB