• André Goddard Rosa's avatar
    vsprintf: reuse almost identical simple_strtoulX() functions · 922ac25c
    André Goddard Rosa authored
    The difference between simple_strtoul() and simple_strtoull() is just
    the size of the variable used to keep track of the sum of characters
    converted to numbers:
    
    unsigned long simple_strtoul() {...}
    unsigned long long simple_strtoull(){...}
    
    Both are same size on my Core 2/gcc 4.4.1.
    Overflow condition is not checked on both functions, so an extremely large
    string can break these functions so that they don't even notice it.
    
    As we do not care for overflowing on these functions, always keep the sum
    using the larger variable around (unsigned long long) on simple_strtoull()
    and cast it to (unsigned long) on simple_strtoul(), which then becomes
    just a wrapper around simple_strtoull().
    
    Code size decreases by 304 bytes:
       text    data     bss     dec     hex filename
      15534       0       8   15542    3cb6 vsprintf.o (ex lib/lib.a-BEFORE)
      15230       0       8   15238    3b86 vsprintf.o (ex lib/lib.a-AFTER)
    Signed-off-by: default avatarAndré Goddard Rosa <andre.goddard@gmail.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    922ac25c
vsprintf.c 46.4 KB