• Mathieu Desnoyers's avatar
    rseq/selftests: fix parametrized test with -fpie · ce01a157
    Mathieu Desnoyers authored
    On x86-64, the parametrized selftest code for rseq crashes with a
    segmentation fault when compiled with -fpie. This happens when the
    param_test binary is loaded at an address beyond 32-bit on x86-64.
    
    The issue is caused by use of a 32-bit register to hold the address
    of the loop counter variable.
    
    Fix this by using a 64-bit register to calculate the address of the
    loop counter variables as an offset from rip.
    Signed-off-by: default avatarMathieu Desnoyers <mathieu.desnoyers@efficios.com>
    Acked-by: default avatar"Paul E . McKenney" <paulmck@linux.vnet.ibm.com>
    Cc: <stable@vger.kernel.org> # v4.18
    Cc: Shuah Khan <shuah@kernel.org>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: Joel Fernandes <joelaf@google.com>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Catalin Marinas <catalin.marinas@arm.com>
    Cc: Dave Watson <davejwatson@fb.com>
    Cc: Will Deacon <will.deacon@arm.com>
    Cc: Andi Kleen <andi@firstfloor.org>
    Cc: linux-kselftest@vger.kernel.org
    Cc: "H . Peter Anvin" <hpa@zytor.com>
    Cc: Chris Lameter <cl@linux.com>
    Cc: Russell King <linux@arm.linux.org.uk>
    Cc: Michael Kerrisk <mtk.manpages@gmail.com>
    Cc: "Paul E . McKenney" <paulmck@linux.vnet.ibm.com>
    Cc: Paul Turner <pjt@google.com>
    Cc: Boqun Feng <boqun.feng@gmail.com>
    Cc: Josh Triplett <josh@joshtriplett.org>
    Cc: Steven Rostedt <rostedt@goodmis.org>
    Cc: Ben Maurer <bmaurer@fb.com>
    Cc: Andy Lutomirski <luto@amacapital.net>
    Cc: Andrew Morton <akpm@linux-foundation.org>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: default avatarShuah Khan (Samsung OSG) <shuah@kernel.org>
    ce01a157
param_test.c 30.2 KB