• Paolo Abeni's avatar
    mptcp: fix data_fin handing in RX path · 9a19371b
    Paolo Abeni authored
    The data fin flag is set only via a DSS option, but
    mptcp_incoming_options() copies it unconditionally from the
    provided RX options.
    
    Since we do not clear all the mptcp sock RX options in a
    socket free/alloc cycle, we can end-up with a stray data_fin
    value while parsing e.g. MPC packets.
    
    That would lead to mapping data corruption and will trigger
    a few WARN_ON() in the RX path.
    
    Instead of adding a costly memset(), fetch the data_fin flag
    only for DSS packets - when we always explicitly initialize
    such bit at option parsing time.
    
    Fixes: 648ef4b8 ("mptcp: Implement MPTCP receive path")
    Reviewed-by: default avatarMat Martineau <mathew.j.martineau@linux.intel.com>
    Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    9a19371b
options.c 27.3 KB