• Hugh Dickins's avatar
    memcg: fix Bad page state after replace_page_cache · 9b7f43af
    Hugh Dickins authored
    My 9ce70c02 "memcg: fix deadlock by inverting lrucare nesting" put a
    nasty little bug into v3.3's version of mem_cgroup_replace_page_cache(),
    sometimes used for FUSE.  Replacing __mem_cgroup_commit_charge_lrucare()
    by __mem_cgroup_commit_charge(), I used the "pc" pointer set up earlier:
    but it's for oldpage, and needs now to be for newpage.  Once oldpage was
    freed, its PageCgroupUsed bit (cleared above but set again here) caused
    "Bad page state" messages - and perhaps worse, being missed from newpage.
    (I didn't find this by using FUSE, but in reusing the function for tmpfs.)
    Signed-off-by: default avatarHugh Dickins <hughd@google.com>
    Cc: stable@vger.kernel.org [v3.3 only]
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    9b7f43af
memcontrol.c 147 KB