• Tejun Heo's avatar
    ps3-vuart: don't use PREPARE_WORK · 4a8bb7f5
    Tejun Heo authored
    PREPARE_[DELAYED_]WORK() are being phased out.  They have few users
    and a nasty surprise in terms of reentrancy guarantee as workqueue
    considers work items to be different if they don't have the same work
    function.
    
    ps3_vuart wasn't overriding the work item with multiple work functions
    but was using NULL for INIT_WORK() and then single PREPARE_WORK() to
    set the work function.  We can simply invoke INIT_WORK() with the work
    function and remove the PREPARE_WORK() usage.
    
    It would probably be best to route this with other related updates
    through the workqueue tree.
    
    Geoff: Tested on ps3 (DECR-1400).
    Signed-off-by: default avatarTejun Heo <tj@kernel.org>
    Acked-by: default avatarGeoff Levand <geoff@infradead.org>
    Cc: linuxppc-dev@lists.ozlabs.org
    Cc: cbe-oss-dev@lists.ozlabs.org
    4a8bb7f5
ps3-vuart.c 30.6 KB