• Richard Weinberger's avatar
    ubifs: Fix journal replay wrt. xattr nodes · a01621bb
    Richard Weinberger authored
    [ Upstream commit 1cb51a15 ]
    
    When replaying the journal it can happen that a journal entry points to
    a garbage collected node.
    This is the case when a power-cut occurred between a garbage collect run
    and a commit. In such a case nodes have to be read using the failable
    read functions to detect whether the found node matches what we expect.
    
    One corner case was forgotten, when the journal contains an entry to
    remove an inode all xattrs have to be removed too. UBIFS models xattr
    like directory entries, so the TNC code iterates over
    all xattrs of the inode and removes them too. This code re-uses the
    functions for walking directories and calls ubifs_tnc_next_ent().
    ubifs_tnc_next_ent() expects to be used only after the journal and
    aborts when a node does not match the expected result. This behavior can
    render an UBIFS volume unmountable after a power-cut when xattrs are
    used.
    
    Fix this issue by using failable read functions in ubifs_tnc_next_ent()
    too when replaying the journal.
    Cc: stable@vger.kernel.org
    Fixes: 1e51764a ("UBIFS: add new flash file system")
    Reported-by: default avatarRock Lee <rockdotlee@gmail.com>
    Reviewed-by: default avatarDavid Gstir <david@sigma-star.at>
    Signed-off-by: default avatarRichard Weinberger <richard@nod.at>
    Signed-off-by: default avatarSasha Levin <alexander.levin@verizon.com>
    a01621bb
tnc.c 87.3 KB