• Pankaj Bharadiya's avatar
    drm/i915: Make WARN* drm specific where uncore or stream ptr is available · a9f236d1
    Pankaj Bharadiya authored
    drm specific WARN* calls include device information in the
    backtrace, so we know what device the warnings originate from.
    
    Covert all the calls of WARN* with device specific drm_WARN*
    variants in functions where intel_uncore/i915_perf_stream  struct
    pointer is readily available.
    
    The conversion was done automatically with below coccinelle semantic
    patch. checkpatch errors/warnings are fixed manually.
    
    @@
    identifier func, T;
    @@
    func(...) {
    ...
    struct intel_uncore *T = ...;
    <...
    (
    -WARN(
    +drm_WARN(&T->i915->drm,
    ...)
    |
    -WARN_ON(
    +drm_WARN_ON(&T->i915->drm,
    ...)
    |
    -WARN_ONCE(
    +drm_WARN_ONCE(&T->i915->drm,
    ...)
    |
    -WARN_ON_ONCE(
    +drm_WARN_ON_ONCE(&T->i915->drm,
    ...)
    )
    ...>
    
    }
    
    @@
    identifier func, T;
    @@
    func(struct intel_uncore *T,...) {
    <...
    (
    -WARN(
    +drm_WARN(&T->i915->drm,
    ...)
    |
    -WARN_ON(
    +drm_WARN_ON(&T->i915->drm,
    ...)
    |
    -WARN_ONCE(
    +drm_WARN_ONCE(&T->i915->drm,
    ...)
    |
    -WARN_ON_ONCE(
    +drm_WARN_ON_ONCE(&T->i915->drm,
    ...)
    )
    ...>
    
    }
    
    @@
    identifier func, T;
    @@
    func(struct i915_perf_stream *T,...) {
    +struct drm_i915_private *i915 = T->perf->i915;
    <+...
    (
    -WARN(
    +drm_WARN(&i915->drm,
    ...)
    |
    -WARN_ON(
    +drm_WARN_ON(&i915->drm,
    ...)
    |
    -WARN_ONCE(
    +drm_WARN_ONCE(&i915->drm,
    ...)
    |
    -WARN_ON_ONCE(
    +drm_WARN_ON_ONCE(&i915->drm,
    ...)
    )
    ...+>
    
    }
    
    command: ls drivers/gpu/drm/i915/*.c | xargs spatch --sp-file <script> \
    					--linux-spacing --in-place
    Signed-off-by: default avatarPankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com>
    Signed-off-by: default avatarJani Nikula <jani.nikula@intel.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/20200115034455.17658-11-pankaj.laxminarayan.bharadiya@intel.com
    a9f236d1
intel_uncore.c 61.4 KB