• Arnaldo Carvalho de Melo's avatar
    perf session: Always initialize ordered_events · aae59fab
    Arnaldo Carvalho de Melo authored
    Even when it is not used to actually reorder events, some of its fields
    are used, like session->ordered_events->tool, to shorten function
    signatures where tool, for instance, was being passed, as the tool is
    needed for the ordered_events code, we need it there and might as well
    use it for other perf_session needs.
    
    This fixes a problem where 'perf script' had some condition that made
    session->ordered_events not to be initialized even with its
    script->tool ordered_events related flags asking for it to be, which
    looks like another bug and needs to be investigated further.
    
    Always initializing session->ordered_events at least leaves the current
    assumptions in place, so do it now.
    Reported-by: default avatarDavid Ahern <dsahern@gmail.com>
    Reviewed-by: default avatarDavid Ahern <dsahern@gmail.com>
    Tested-by: default avatarDavid Ahern <dsahern@gmail.com>
    Cc: Adrian Hunter <adrian.hunter@intel.com>
    Cc: Borislav Petkov <bp@suse.de>
    Cc: Don Zickus <dzickus@redhat.com>
    Cc: Frederic Weisbecker <fweisbec@gmail.com>
    Cc: Jiri Olsa <jolsa@redhat.com>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Stephane Eranian <eranian@google.com>
    Link: http://lkml.kernel.org/n/tip-b1xxk0rwkz2a0gip1uufmjqg@git.kernel.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    aae59fab
session.c 46.1 KB