• Eric W. Biederman's avatar
    [PATCH] Fix SAK_work workqueue initialization. · 7f1f86a0
    Eric W. Biederman authored
    Somewhere in the rewrite of the work queues my cleanup of SAK handling
    got broken.  Maybe I didn't retest it properly or possibly the API
    was changing so fast I missed something.  Regardless currently
    triggering a SAK now generates an ugly BUG_ON and kills the kernel.
    
    Thanks to Alexey Dobriyan <adobriyan@openvz.org> for spotting this.
    
    This modifies the use of SAK_work to initialize it when the data
    structure it resides in is initialized, and to simply call
    schedule_work when we need to generate a SAK.  I update both
    data structures that have a SAK_work member for consistency.
    
    All of the old PREPARE_WORK calls that are now gone.
    
    If we call schedule_work again before it has processed it
    has generated the first SAK it will simply ignore the duplicate
    schedule_work request.
    Signed-off-by: default avatarEric W. Biederman <ebiederm@xmission.com>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    7f1f86a0
tty_io.c 99.1 KB