• Dick Hollenbeck's avatar
    serial: 8250: add serial transmitter fully empty test · bca47613
    Dick Hollenbeck authored
    When controlling an industrial radio modem it can be necessary to
    manipulate the handshake lines in order to control the radio modem's
    transmitter, from userspace.
    
    The transmitter should not be turned off before all characters have been
    transmitted.  serial8250_tx_empty() was reporting that all characters were
    transmitted before they actually were.
    
    ===
    
    Discovered in parallel with more testing and analysis by Kees Schoenmakers
    as follows:
    
    I ran into an NetMos 9835 serial pci board which behaves a little
    different than the standard.  This type of expansion board is very common.
    
    "Standard" 8250 compatible devices clear the 'UART_LST_TEMT" bit together
    with the "UART_LSR_THRE" bit when writing data to the device.
    
    The NetMos device does it slightly different
    
    I believe that the TEMT bit is coupled to the shift register.  The problem
    is that after writing data to the device and very quickly after that one
    does call serial8250_tx_empty, it returns the wrong information.
    
    My patch makes the test more robust (and solves the problem) and it does
    not affect the already correct devices.
    
    Alan:
    
      We may yet need to quirk this but now we know which chips we have a
      way to do that should we find this breaks some other 8250 clone with
      dodgy THRE.
    Signed-off-by: default avatarDick Hollenbeck <dick@softplc.com>
    Signed-off-by: default avatarAlan Cox <alan@linux.intel.com>
    Cc: Kees Schoenmakers <k.schoenmakers@sigmae.nl>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Cc: stable <stable@kernel.org>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
    bca47613
8250.c 81.5 KB