• NeilBrown's avatar
    md/bitmap: return an error when bitmap superblock is corrupt. · b1dd5485
    NeilBrown authored
    commit b97e9257 upstream
        Use separate bitmaps for each nodes in the cluster
    
    bitmap_read_sb() validates the bitmap superblock that it reads in.
    If it finds an inconsistency like a bad magic number or out-of-range
    version number, it prints an error and returns, but it incorrectly
    returns zero, so the array is still assembled with the (invalid) bitmap.
    
    This means it could try to use a bitmap with a new version number which
    it therefore does not understand.
    
    This bug was introduced in 3.5 and fix as part of a larger patch in 4.1.
    So the patch is suitable for any -stable kernel in that range.
    
    Fixes: 27581e5a ("md/bitmap: centralise allocation of bitmap file pages.")
    Signed-off-by: default avatarNeilBrown <neilb@suse.com>
    Reported-by: default avatarGuoQing Jiang <gqjiang@suse.com>
    Signed-off-by: default avatarLuis Henriques <luis.henriques@canonical.com>
    b1dd5485
bitmap.c 59.2 KB