• Pavel Emelyanov's avatar
    [INET]: Don't create tunnels with '%' in name. · b37d428b
    Pavel Emelyanov authored
    Four tunnel drivers (ip_gre, ipip, ip6_tunnel and sit) can receive a
    pre-defined name for a device from the userspace.  Since these drivers
    call the register_netdevice() (rtnl_lock, is held), which does _not_
    generate the device's name, this name may contain a '%' character.
    
    Not sure how bad is this to have a device with a '%' in its name, but
    all the other places either use the register_netdev(), which call the
    dev_alloc_name(), or explicitly call the dev_alloc_name() before
    registering, i.e. do not allow for such names.
    
    This had to be prior to the commit 34cc7b, but I forgot to number the
    patches and this one got lost, sorry.
    Signed-off-by: default avatarPavel Emelyanov <xemul@openvz.org>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    b37d428b
sit.c 21.3 KB