• Liu Bo's avatar
    Btrfs: catch transaction abortion after waiting for it · b4924a0f
    Liu Bo authored
    This problem is uncovered by a test case: http://patchwork.ozlabs.org/patch/244297.
    
    Fsync() can report success when it actually doesn't.  When we
    have several threads running fsync() at the same tiem and in one fsync() we
    get a transaction abortion due to some problems(in the test case it's disk
    failures), and other fsync()s may return successfully which makes userspace
    programs think that data is now safely flushed into disk.
    
    It's because that after fsyncs() fail btrfs_sync_log() due to disk failures,
    they get to try btrfs_commit_transaction() where it finds that there is
    already a transaction being committed, and they'll just call wait_for_commit()
    and return.  Note that we actually check "trans->aborted" in btrfs_end_transaction,
    but it's likely that the error message is still not yet throwed out and only after
    wait_for_commit() we're sure whether the transaction is committed successfully.
    
    This add the necessary check and it now passes the test.
    Signed-off-by: default avatarLiu Bo <bo.li.liu@oracle.com>
    Signed-off-by: default avatarChris Mason <clm@fb.com>
    b4924a0f
transaction.c 59.2 KB