• Martin DEVERA's avatar
    pinctrl: sx150x: Fix pinctrl enablement order bug · 6d8e04f9
    Martin DEVERA authored
    I encountered bug in SX1502 expander driver in 5.7.7. Here is relevant
    DTS part:
    
    compatible = "semtech,sx1502q";
    gpio4_cfg_pins: gpio2-cfg {
                             pins = "gpio5";
                             output-high;
         };
    
    And part of OOPS:
    
    [    0.673996] [<c023cfa6>] (gpiochip_get_data) from [<c023b235>]
    (sx150x_gpio_direction_output+0xd)
    [    0.683259] [<c023b235>] (sx150x_gpio_direction_output) from
    [<c023b363>] (sx150x_pinconf_set+0x)
    [    0.692796] [<c023b363>] (sx150x_pinconf_set) from [<c0238fef>]
    (pinconf_apply_setting+0x39/0x7e)
    [    0.701635] [<c0238fef>] (pinconf_apply_setting) from [<c0236c77>]
    (pinctrl_commit_state+0xa5/0x)
    [    0.710648] [<c0236c77>] (pinctrl_commit_state) from [<c0237e03>]
    (pinctrl_enable+0xff/0x1d4)
    [    0.719139] [<c0237e03>] (pinctrl_enable) from [<c023b791>]
    (sx150x_probe+0x1a3/0x358)
    [    0.727027] [<c023b791>] (sx150x_probe) from [<c02c38bf>]
    (i2c_device_probe+0x1bb/0x1dc)
    
    The problem is that sx150x_pinconf_set uses sx150x_gpio_direction_output
    but gpio is not setup yet. Patch below fixes it but I'm not sure whether
    is it correct.
    
    Link: https://lore.kernel.org/r/f32130bf-cfd4-b1bf-538c-dbc9ee2d947a@eaxlabs.czSigned-off-by: default avatarMartin DEVERA <devik@eaxlabs.cz>
    Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
    6d8e04f9
pinctrl-sx150x.c 29.1 KB