• Andreas Mohr's avatar
    ALSA: azt3328: fix previous breakage, improve suspend, cleanups · 78df617a
    Andreas Mohr authored
    - fix my previous codec activity breakage (_non-warned_ variable assignment
      issue)
    - convert suspend/resume to 32bit I/O access (I/O is painful; to improve
      suspend/resume performance)
    - change DEBUG_PLAY_REC to DEBUG_CODEC for consistency
    - printk cleanup
    - some logging improvements
    - minor cleanup/improvements
    
    The variable assignment issue above was a conditional assignment to the
    call_function variable (this ended with the non-preinitialized variable
    not getting assigned in some cases, thus a dangling stack value, yet gcc 4.3.3
    unbelievably did _NOT_ warn about it in this case!!),
    needed to change this into _always_ assigning the check result.
    Practical result of this bug was that when shutting down
    _either_ playback or capture, _both_ streams dropped dead :P
    
    Tested, working (plus resume) and checkpatch.pl:ed on 2.6.30-rc5,
    applies cleanly to 2.6.30 proper with my previous (committed)
    patches applied.
    Signed-off-by: default avatarAndreas Mohr <andi@lisas.de>
    Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
    78df617a
azt3328.h 15.5 KB