• Christian Lamparter's avatar
    carl9170: fix debugfs crashes · ba77f1da
    Christian Lamparter authored
    commit 6ee6d1cb upstream.
    
    Ben Greear reported:
    > I see lots of instability as soon as I load up the carl9710 NIC.
    > My application is going to be poking at it's debugfs files...
    >
    > BUG: KASAN: slab-out-of-bounds in carl9170_debugfs_read+0xd5/0x2a0
    > [carl9170] at addr 0xffff8801bc1208b0
    > Read of size 8 by task btserver/5888
    > =======================================================================
    > BUG kmalloc-256 (Tainted: G        W      ): kasan: bad access detected
    > -----------------------------------------------------------------------
    >
    > INFO: Allocated in seq_open+0x50/0x100 age=2690 cpu=2 pid=772
    >...
    
    This breakage was caused by the introduction of intermediate
    fops in debugfs by commit 9fd4dcec
    ("debugfs: prevent access to possibly dead file_operations at file open")
    
    Thankfully, the original/real fops are still available in d_fsdata.
    Reported-by: default avatarBen Greear <greearb@candelatech.com>
    Signed-off-by: default avatarChristian Lamparter <chunkeey@gmail.com>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    ba77f1da
debug.c 23.4 KB