• Vasily Averin's avatar
    [NET]: "wrong timeout value" in sk_wait_data() v2 · ba78073e
    Vasily Averin authored
    sys_setsockopt() do not check properly timeout values for
    SO_RCVTIMEO/SO_SNDTIMEO, for example it's possible to set negative timeout
    values. POSIX do not defines behaviour for sys_setsockopt in case negative
    timeouts, but requires that setsockopt() shall fail with -EDOM if the send and
    receive timeout values are too big to fit into the timeout fields in the socket
    structure.
    In current implementation negative timeout can lead to error messages like
    "schedule_timeout: wrong timeout value".
    
    Proposed patch:
    - checks tv_usec and returns -EDOM if it is wrong
    - do not allows to set negative timeout values (sets 0 instead) and outputs
    ratelimited information message about such attempts.
    Signed-off-By: default avatarVasily Averin <vvs@sw.ru>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    ba78073e
sock.c 49.7 KB