• Trond Myklebust's avatar
    nfsd: Reset the boot verifier on all write I/O errors · bbf2f098
    Trond Myklebust authored
    If multiple clients are writing to the same file, then due to the fact
    we share a single file descriptor between all NFSv3 clients writing
    to the file, we have a situation where clients can miss the fact that
    their file data was not persisted. While this should be rare, it
    could cause silent data loss in situations where multiple clients
    are using NLM locking or O_DIRECT to write to the same file.
    Unfortunately, the stateless nature of NFSv3 and the fact that we
    can only identify clients by their IP address means that we cannot
    trivially cache errors; we would not know when it is safe to
    release them from the cache.
    
    So the solution is to declare a reboot. We understand that this
    should be a rare occurrence, since disks are usually stable. The
    most frequent occurrence is likely to be ENOSPC, at which point
    all writes to the given filesystem are likely to fail anyway.
    
    So the expectation is that clients will be forced to retry their
    writes until they hit the fatal error.
    Signed-off-by: default avatarTrond Myklebust <trond.myklebust@hammerspace.com>
    Signed-off-by: default avatarJ. Bruce Fields <bfields@redhat.com>
    bbf2f098
vfs.c 49.9 KB