• Dan Carpenter's avatar
    drm/amd/amdgpu: Fix debugfs error handling · d344b21b
    Dan Carpenter authored
    The error handling is wrong and "ent" could be NULL we when dereference
    it to get "ent->d_inode".
    
    The thing is that normally debugfs_create_file() is not supposed to
    require (or have) any error handling.  That function does return error
    pointers if debugfs is turned off but we know it's enable here.  When
    it's enabled, then it returns NULL on error.
    
    So what I did was I stripped out all the error handling except around
    the i_size_write().  I could have just used a NULL check instead of an
    IS_ERR_OR_NULL() but I figured this was more clear because that way you
    don't have to look at the surrounding code to see whether debugfs is
    enabled or not.
    Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
    Reviewed-by: default avatarChristian König <christian.koenig@amd.com>
    Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
    d344b21b
amdgpu_debugfs.c 24 KB