• Joe Perches's avatar
    drivers/net/tulip/eeprom.c: fix bogus "(null)" in tulip init messages · c251c7f7
    Joe Perches authored
    On Wed, 2010-03-10 at 08:41 -0800, David Miller wrote:
    > From: Mikael Pettersson <mikpe@it.uu.se>
    > Date: Wed, 10 Mar 2010 16:33:28 +0100
    > > Booting 2.6.34-rc1 on a machine with a tulip nic I see
    > > a number of kernel messages that include "(null)" where
    > > previous kernels included the string "tulip0":
    > CC:'ing the guilty party :-)  It's one of the following
    > commits:
    
    Thanks Mikael.
    
    Anonymity has some good attributes.
    Blame avoidance is one of them.
    
    I've broad shoulders.  It's me, then Dwight Howard...
    
    There might be another few of these where ->name or ->dev
    was used before struct device or net_device was registered.
    I'll go back and check.
    
    tulip_core has:
    
    	if (tp->flags & HAS_MEDIA_TABLE) {
    		sprintf(dev->name, DRV_NAME "%d", board_idx);	/* hack */
    		tulip_parse_eeprom(dev);
    		strcpy(dev->name, "eth%d");			/* un-hack */
    	}
    
    So I don't feel _too_ bad.
    
    tulip_parse_eeprom is done before register_netdev so the logging
    there can not use netdev_<level> or dev_<level>(&dev->dev
    Signed-off-by: default avatarJoe Perches <joe@perches.com>
    Tested-by: default avatarMikael Pettersson <mikpe@it.uu.se>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    c251c7f7
eeprom.c 12.4 KB