• Ralf Baechle's avatar
    Fix/Rewrite of the mipsnet driver] · c800c5c9
    Ralf Baechle authored
    This is Thiemo's patch.
    
    ----- Forwarded message from Thiemo Seufer <ths@networkno.de> -----
    
    From: Thiemo Seufer <ths@networkno.de>
    Date: Sat, 17 Nov 2007 22:29:13 +0000
    To: netdev@vger.kernel.org
    Cc: linux-mips@linux-mips.org, ralf@linux-mips.org
    Subject: [PATCH, REPOST] Fix/Rewrite of the mipsnet driver
    Content-Type: text/plain; charset=us-ascii
    
    Hello All,
    
    currently the mipsnet driver fails after transmitting a number of
    packages because SKBs are allocated but never freed. I fixed that
    and coudn't refrain from removing the most egregious warts.
    
    - mipsnet.h folded into mipsnet.c, as it doesn't provide any
      useful external interface.
    - Free SKB after transmission.
    - Call free_irq in mipsnet_close, to balance the request_irq in
      mipsnet_open.
    - Removed duplicate read of rxDataCount.
    - Some identifiers are now less verbose.
    - Removed dead and/or unnecessarily complex code.
    - Code formatting fixes.
    
    Tested on Qemu's mipssim emulation, with this patch it can boot a
    Debian NFSroot.
    
    Thiemo
    Signed-off-by: default avatarThiemo Seufer <ths@networkno.de>
    Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    c800c5c9
mipsnet.c 7.94 KB