• Shan Wei's avatar
    r8169: fix checksum broken · d5d3ebe3
    Shan Wei authored
    If r8196 received packets with invalid sctp/igmp(not tcp, udp) checksum, r8196 set skb->ip_summed
    wit CHECKSUM_UNNECESSARY. This cause that upper protocol don't check checksum field.
    
    I am not family with r8196 driver. I try to guess the meaning of RxProtoIP and IPFail.
    RxProtoIP stands for received IPv4 packet that upper protocol is not tcp and udp.
    !(opts1 & IPFail) is true means that driver correctly to check checksum in IPv4 header.
    
    If it's right, I think we should not set ip_summed wit CHECKSUM_UNNECESSARY for my sctp packets
    with invalid checksum.
    
    If it's not right, please tell me.
    Signed-off-by: default avatarShan Wei <shanwei@cn.fujitsu.com>
    Acked-by: default avatarFrancois Romieu <romieu@fr.zoreil.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    d5d3ebe3
r8169.c 117 KB