• Arnd Bergmann's avatar
    pinctrl: hide PCONFDUMP in #ifdef · 4f06266a
    Arnd Bergmann authored
    The zynq and qcom-spmi pinctrl drivers both use pin_config_item arrays
    to provide extra interfaces in debugfs. This structure and the
    PCONFDUMP macro are not defined if CONFIG_DEBUG_FS is turned off,
    so we get build errors like:
    
    pinctrl/qcom/pinctrl-spmi-gpio.c:139:37: error: array type has incomplete element type
     static const struct pin_config_item pmic_conf_items[ARRAY_SIZE(pmic_gpio_bindings)] = {
                                         ^
    pinctrl/qcom/pinctrl-spmi-gpio.c:140:2: error: implicit declaration of function 'PCONFDUMP' [-Werror=implicit-function-declaration]
      PCONFDUMP(PMIC_GPIO_CONF_PULL_UP,  "pull up strength", NULL, true),
      ^
    pinctrl/qcom/pinctrl-spmi-gpio.c:139:37: warning: 'pmic_conf_items' defined but not used [-Wunused-variable]
     static const struct pin_config_item pmic_conf_items[ARRAY_SIZE(pmic_gpio_bindings)] = {
    
    Lacking any better idea to solve this nicely, this patch uses #ifdef
    to hide the structures, just like the pinctrl core does.
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
    4f06266a
pinctrl-zynq.c 40.3 KB