• Nicholas Bellinger's avatar
    target: Release COMPARE_AND_WRITE mutex in generic failure path · cf6d1f09
    Nicholas Bellinger authored
    This patch adds a extra check for SCF_COMPARE_AND_WRITE within
    transport_generic_request_failure() to invoke the callback for
    compare_and_write_callback() or compare_and_write_done(), in
    order to release se_dev->caw_mutex from the generic failure
    path.
    
    It also adds to checks within compare_and_write_callback() to
    avoid processing when transport_generic_request_failure() occurs
    early enough that cmd->t_data_sg or cmd->t_bidi_data_sg have not
    been setup yet, nor se_dev->caw_mutex obtained from within
    sbc_compare_and_write().
    
    v4 changes:
     - Add explicit check for cmd->transport_complete_callback in
       transport_generic_request_failure() to handle case where
       sbc_compare_and_write()clears callback pointer (Dan Carpenter)
    
    Cc: Christoph Hellwig <hch@lst.de>
    Cc: Hannes Reinecke <hare@suse.de>
    Cc: Martin Petersen <martin.petersen@oracle.com>
    Cc: Chris Mason <chris.mason@fusionio.com>
    Cc: James Bottomley <JBottomley@Parallels.com>
    Cc: Nicholas Bellinger <nab@linux-iscsi.org>
    Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
    cf6d1f09
target_core_transport.c 80.3 KB