• NeilBrown's avatar
    sunrpc: Simplify cache_defer_req and related functions. · d29068c4
    NeilBrown authored
    The return value from cache_defer_req is somewhat confusing.
    Various different error codes are returned, but the single caller is
    only interested in success or failure.
    
    In fact it can measure this success or failure itself by checking
    CACHE_PENDING, which makes the point of the code more explicit.
    
    So change cache_defer_req to return 'void' and test CACHE_PENDING
    after it completes, to see if the request was actually deferred or
    not.
    
    Similarly setup_deferral and cache_wait_req don't need a return value,
    so make them void and remove some code.
    
    The call to cache_revisit_request (to guard against a race) is only
    needed for the second call to setup_deferral, so move it out of
    setup_deferral to after that second call.  With the first call the
    race is handled differently (by explicitly calling
    'wait_for_completion').
    Signed-off-by: default avatarNeilBrown <neilb@suse.de>
    Signed-off-by: default avatarJ. Bruce Fields <bfields@redhat.com>
    d29068c4
cache.c 42.1 KB