• Kent Overstreet's avatar
    bcache: Fix a dumb race · 6aa8f1a6
    Kent Overstreet authored
    In the far-too-complicated closure code - closures can have destructors,
    for probably dubious reasons; they get run after the closure is no
    longer waiting on anything but before dropping the parent ref, intended
    just for freeing whatever memory the closure is embedded in.
    
    Trouble is, when remaining goes to 0 and we've got nothing more to run -
    we also have to unlock the closure, setting remaining to -1. If there's
    a destructor, that unlock isn't doing anything - nobody could be trying
    to lock it if we're about to free it - but if the unlock _is needed...
    that check for a destructor was racy. Argh.
    Signed-off-by: default avatarKent Overstreet <kmo@daterainc.com>
    Cc: linux-stable <stable@vger.kernel.org> # >= v3.10
    6aa8f1a6
closure.c 7.64 KB