• Jakub Kicinski's avatar
    bpf: don't zero out the info struct in bpf_obj_get_info_by_fd() · d777b2dd
    Jakub Kicinski authored
    The buffer passed to bpf_obj_get_info_by_fd() should be initialized
    to zeros.  Kernel will enforce that to guarantee we can safely extend
    info structures in the future.
    
    Making the bpf_obj_get_info_by_fd() call in libbpf perform the zeroing
    is problematic, however, since some members of the info structures
    may need to be initialized by the callers (for instance pointers
    to buffers to which kernel is to dump translated and jited images).
    
    Remove the zeroing and fix up the in-tree callers before any kernel
    has been released with this code.
    
    As Daniel points out this seems to be the intended operation anyway,
    since commit 95b9afd3 ("bpf: Test for bpf ID") is itself setting
    the buffer pointers before calling bpf_obj_get_info_by_fd().
    Signed-off-by: default avatarJakub Kicinski <jakub.kicinski@netronome.com>
    Acked-by: default avatarDaniel Borkmann <daniel@iogearbox.net>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    d777b2dd
test_progs.c 13.9 KB