• Jakub Kicinski's avatar
    rtnetlink: avoid frame size warning in rtnl_newlink() · a2939745
    Jakub Kicinski authored
    Standard kernel compilation produces the following warning:
    
    net/core/rtnetlink.c: In function ‘rtnl_newlink’:
    net/core/rtnetlink.c:3232:1: warning: the frame size of 1288 bytes is larger than 1024 bytes [-Wframe-larger-than=]
     }
      ^
    
    This should not really be an issue, as rtnl_newlink() stack is
    generally quite shallow.
    
    Fix the warning by allocating attributes with kmalloc() in a wrapper
    and passing it down to rtnl_newlink(), avoiding complexities on error
    paths.
    
    Alternatively we could kmalloc() some structure within rtnl_newlink(),
    slave attributes look like a good candidate.  In practice it adds to
    already rather high complexity and length of the function.
    Signed-off-by: default avatarJakub Kicinski <jakub.kicinski@netronome.com>
    Reviewed-by: default avatarDavid Ahern <dsahern@gmail.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    a2939745
rtnetlink.c 122 KB