• Paul Mundt's avatar
    sh: fix miscompilation of ip_fast_csum with gcc >= 4.3 · d02d6be5
    Paul Mundt authored
    As noted by Matthew Wilcox:
    
        Kyle McMartin just tracked down a bug on parisc to a missing
        "memory" clobber in the inline assembly implementation of
        ip_fast_csum.  The FRV, SH and Xtensa ports are also missing a
        memory clobber, so I thought it would be polite to let you know.
    
        The bug manifests as dropped network packets (obviously they have
        the wrong checksum).  It started appearing for parisc with GCC 4.3.
    
        The GCC manual says:
    
         If your assembler instructions access memory in an unpredictable
         fashion, add `memory' to the list of clobbered registers.  This
         will cause GCC to not keep memory values cached in registers
         across the assembler instruction and not optimize stores or loads
         to that memory.
    
        I see that FRV has a 400 byte memory output which may prevent this
        problem from appearing, but SH and Xtensa have nothing to prevent
        this bug.  Hope this saves you a few days of debugging.
    Signed-off-by: default avatarPaul Mundt <lethal@linux-sh.org>
    d02d6be5
checksum_32.h 5.28 KB