• Jun'ichi Nomura's avatar
    [PATCH] clean up add_bd_holder() · df6c0cd9
    Jun'ichi Nomura authored
    add_bd_holder() is called from bd_claim_by_kobject to put a given struct
    bd_holder in the list if there is no matching entry.
    
    There are 3 possible results of add_bd_holder():
      1. there is no matching entry and add the given one to the list
      2. there is matching entry, so just increment reference count of
         the existing one
      3. something failed during its course
    
    1 and 2 are successful cases.  But for case 2, someone has to free the
    unused struct bd_holder.
    
    The current code frees it inside of add_bd_holder and returns same value
    0 for both cases 1 and 2.  However, it's natural and less error-prone if
    caller frees it since it's allocated by the caller.
    Signed-off-by: default avatarJun'ichi Nomura <j-nomura@ce.jp.nec.com>
    Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
    df6c0cd9
block_dev.c 31.9 KB