• Abhay Salunke's avatar
    [PATCH] dell_rbu: enhancements and fixes · e61c0e33
    Abhay Salunke authored
    BUG fixes:
    
      The driver used to allocate memory with spinlock held which has been
      fixed in this patch.
    
      The driver was printing the entire buffer when it received a invalid
      entry in image_type.  The fix is to only print a warning message and not
      the buffer.
    
    Usability enhancements:
    
      It is possible that due to user error the /sys/class/firmware/dell_rbu
      entries might be missing, this can happen if the user does the following
    
    	echo 1 > /sys/class/firmware/dell_rbu/loading
    	echo 0 > /sys/class/firmware/dell_rbu/loading
    
      This will make the entries in /sys/class/firmware/ to disappear and the
      only way get them back was bby unloading and loading the driver.
    
      This patch makes the user recreate these entries by echoing init in to
      image_type.
    
    This patch has been tested with Libsmbios and Dell OpenManage.
    Signed-off-by: default avatarAbhay Salunke <Abhay_Salunke@dell.com>
    Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
    e61c0e33
dell_rbu.c 17.1 KB