• Mathieu Malaterre's avatar
    powerpc: Add __printf verification to prom_printf · eae5f709
    Mathieu Malaterre authored
    __printf is useful to verify format and arguments. Fix arg mismatch
    reported by gcc, remove the following warnings (with W=1):
    
      arch/powerpc/kernel/prom_init.c:1467:31: error: format ‘%x’ expects argument of type ‘unsigned int’, but argument 2 has type ‘long unsigned int’
      arch/powerpc/kernel/prom_init.c:1471:31: error: format ‘%x’ expects argument of type ‘unsigned int’, but argument 2 has type ‘long unsigned int’
      arch/powerpc/kernel/prom_init.c:1504:33: error: format ‘%x’ expects argument of type ‘unsigned int’, but argument 2 has type ‘long unsigned int’
      arch/powerpc/kernel/prom_init.c:1505:33: error: format ‘%x’ expects argument of type ‘unsigned int’, but argument 2 has type ‘long unsigned int’
      arch/powerpc/kernel/prom_init.c:1506:33: error: format ‘%x’ expects argument of type ‘unsigned int’, but argument 2 has type ‘long unsigned int’
      arch/powerpc/kernel/prom_init.c:1507:33: error: format ‘%x’ expects argument of type ‘unsigned int’, but argument 2 has type ‘long unsigned int’
      arch/powerpc/kernel/prom_init.c:1508:33: error: format ‘%x’ expects argument of type ‘unsigned int’, but argument 2 has type ‘long unsigned int’
      arch/powerpc/kernel/prom_init.c:1509:33: error: format ‘%x’ expects argument of type ‘unsigned int’, but argument 2 has type ‘long unsigned int’
      arch/powerpc/kernel/prom_init.c:1975:39: error: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 2 has type ‘unsigned int’
      arch/powerpc/kernel/prom_init.c:1986:27: error: format ‘%x’ expects argument of type ‘unsigned int’, but argument 2 has type ‘long unsigned int’
      arch/powerpc/kernel/prom_init.c:2567:38: error: format ‘%x’ expects argument of type ‘unsigned int’, but argument 2 has type ‘long unsigned int’
      arch/powerpc/kernel/prom_init.c:2567:46: error: format ‘%x’ expects argument of type ‘unsigned int’, but argument 3 has type ‘long unsigned int’
      arch/powerpc/kernel/prom_init.c:2569:38: error: format ‘%x’ expects argument of type ‘unsigned int’, but argument 2 has type ‘long unsigned int’
      arch/powerpc/kernel/prom_init.c:2569:46: error: format ‘%x’ expects argument of type ‘unsigned int’, but argument 3 has type ‘long unsigned int’
    
    The patch also include arg mismatch fix for case with #define DEBUG_PROM
    (warning not listed here).
    
    This patch fix also the following warnings revealed by checkpatch:
    
      WARNING: Prefer using '"%s...", __func__' to using 'alloc_up', this function's name, in a string
      #101: FILE: arch/powerpc/kernel/prom_init.c:1235:
      + prom_debug("alloc_up(%lx, %lx)\n", size, align);
    
    and
    
      WARNING: Prefer using '"%s...", __func__' to using 'alloc_down', this function's name, in a string
      #138: FILE: arch/powerpc/kernel/prom_init.c:1278:
      + prom_debug("alloc_down(%lx, %lx, %s)\n", size, align,
    Signed-off-by: default avatarMathieu Malaterre <malat@debian.org>
    Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
    eae5f709
prom_init.c 84.9 KB