• Dan Robertson's avatar
    usb: dwc3: meson-g12a: fix shared reset control use · 7a410953
    Dan Robertson authored
    The reset is a shared reset line, but reset_control_reset is still used
    and reset_control_deassert is not guaranteed to have been called before
    the first reset_control_assert call. When suspending the following
    warning may be seen:
    
    WARNING: CPU: 1 PID: 5530 at drivers/reset/core.c:355 reset_control_assert+0x184/0x19c
    Hardware name: Hardkernel ODROID-N2 (DT)
    [..]
    pc : reset_control_assert+0x184/0x19c
    lr : dwc3_meson_g12a_suspend+0x68/0x7c
    [..]
    Call trace:
     reset_control_assert+0x184/0x19c
     dwc3_meson_g12a_suspend+0x68/0x7c
     platform_pm_suspend+0x28/0x54
     __device_suspend+0x590/0xabc
     dpm_suspend+0x104/0x404
     dpm_suspend_start+0x84/0x1bc
     suspend_devices_and_enter+0xc4/0x4fc
     pm_suspend+0x198/0x2d4
    
    Fixes: 6d9fa35a ("usb: dwc3: meson-g12a: get the reset as shared")
    Signed-off-by: default avatarDan Robertson <dan@dlrobertson.com>
    Signed-off-by: default avatarFelipe Balbi <balbi@kernel.org>
    7a410953
dwc3-meson-g12a.c 25.1 KB