• Mikael Pettersson's avatar
    sparc32: unbreak arch_write_unlock() · 3f6aa0b1
    Mikael Pettersson authored
    The sparc32 version of arch_write_unlock() is just a plain assignment.
    Unfortunately this allows the compiler to schedule side-effects in a
    protected region to occur after the HW-level unlock, which is broken.
    E.g., the following trivial test case gets miscompiled:
    
    	#include <linux/spinlock.h>
    	rwlock_t lock;
    	int counter;
    	void foo(void) { write_lock(&lock); ++counter; write_unlock(&lock); }
    
    Fixed by adding a compiler memory barrier to arch_write_unlock().  The
    sparc64 version combines the barrier and assignment into a single asm(),
    and implements the operation as a static inline, so that's what I did too.
    
    Compile-tested with sparc32_defconfig + CONFIG_SMP=y.
    Signed-off-by: default avatarMikael Pettersson <mikpe@it.uu.se>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    3f6aa0b1
spinlock_32.h 4.67 KB