• Maxim Levitsky's avatar
    KVM: x86: fix MSR_IA32_TSC read for nested migration · ee6fa053
    Maxim Levitsky authored
    MSR reads/writes should always access the L1 state, since the (nested)
    hypervisor should intercept all the msrs it wants to adjust, and these
    that it doesn't should be read by the guest as if the host had read it.
    
    However IA32_TSC is an exception. Even when not intercepted, guest still
    reads the value + TSC offset.
    The write however does not take any TSC offset into account.
    
    This is documented in Intel's SDM and seems also to happen on AMD as well.
    
    This creates a problem when userspace wants to read the IA32_TSC value and then
    write it. (e.g for migration)
    
    In this case it reads L2 value but write is interpreted as an L1 value.
    To fix this make the userspace initiated reads of IA32_TSC return L1 value
    as well.
    
    Huge thanks to Dave Gilbert for helping me understand this very confusing
    semantic of MSR writes.
    Signed-off-by: default avatarMaxim Levitsky <mlevitsk@redhat.com>
    Message-Id: <20200921103805.9102-2-mlevitsk@redhat.com>
    Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
    ee6fa053
x86.c 281 KB